Our great sponsors
-
-
-
WorkOS
The modern identity platform for B2B SaaS. The APIs are flexible and easy-to-use, supporting authentication, user identity, and complex enterprise features like SSO and SCIM provisioning.
a lot of refactoring and housekeeping, both from a cleanliness point of view and from a making it easier to maintain point of view. an example of this is that when we forked, the repo had several full third party libraries embedded in the repo, instead of just marking them as dependencies that kodi could install and update separately. needless to say, they were very out of date. Or some fun stuff like the infamous Void.
On top of that, their dev practices continue to be kinda atrocious from a support standpoint if I'm going to be honest. This is a longstanding issue we've had with a lot of the inherited code. Typically you can use commits and git blame to go back in time and see when/why a piece of code was added to the project. That's not possible here. They don't make clean PRs. They make a bunch of commits then merge them all at once. When they do make PRs, it's always nondescriptive names with no descriptions so you have no idea what code is actually doing what in that version. For example: https://github.com/MediaBrowser/plugin.video.emby/pull/400. It's not even remotely worth my time to try to keep up with them and decipher what they're doing, or if what they're changing even effects our addon. And I've seen the code quality that comes from them, it's probably not worth our time to try to copy or even reference it. Not claiming that I'm any better, but if I'm going to clean up bad code, I like having it be my bad code, you know?