python-adblock VS setuptools

Since version 2.0.0, if the Python adblock library is available, it will be used to integrate Brave’s Rust adblocker library for improved adblocking, based on ABP-like filter lists (such as EasyList)

Ah, yup, I can reproduce with that, thanks! I opened an issue here: Loading adblock cache takes 2-4s with huge cache file · Issue #62 · ArniDagur/python-adblock

From adblock on PyPI (the Python package index):

FYI Qutebrowser is has a pretty good ad-blocker since 2.0

> Since version 2.0.0, if the Python adblock library is available, it will be used to integrate Brave’s Rust adblocker library for improved adblocking, based on ABP-like filter lists (such as EasyList). If that library is unavailable or on older versions of qutebrowser, a simpler built-in ad blocker is used instead. It takes /etc/hosts-like lists and thus is only able to block entire hosts.

You just need optional dependancy https://pypi.org/project/adblock/

How would I make adblock "available" on Windows? I found the python scripts here, but I have no clue where qutebrowser would be looking for these?

There are various solutions to this - see point 21 in the FAQ

Purely a maintenance thing - faster windows releases and not having to take care of 32-bit support for the adblock library.

You will need the (optional) adblock Python library. Once you have that installed, with the default content.blocking.method = auto setting, it'll be enabled automatically. You can also set the setting to adblock explicitly, then you'll get a warning if the library wasn't found.

To be fair, that seems to have been a 2 year warning:

https://github.com/pypa/setuptools/commit/3544de73b3662a27fa...

There was/is some discussion in setuptools about how to normalize the tarball (https://github.com/pypa/setuptools/issues/2133#issuecomment-...) coudl something similar be applied to Building Python itself ?

❯ yay -Sy python-setuptools python-jaraco.text ❯ pip show setuptools Name: setuptools Version: 67.7.0 Summary: Easily download, build, install, upgrade, and uninstall Python packages Home-page: https://github.com/pypa/setuptools Author: Python Packaging Authority Author-email: [email protected] License: Location: /usr/lib/python3.11/site-packages Requires: jaraco.text, more-itertools, ordered-set, packaging, platformdirs, tomli, validate-pyproject Required-by: Cerberus, fs, httpie, input-remapper, pecan, pycountry, python-lsp-server, reuse, setuptools-scm, zc.lockfile

Link: https://github.com/pypa/setuptools/issues/3772

For example, when it comes to Python, one option is to use the same packaging system that a huge number of open-source libraries and tools are published with. You can use setuptools or Hatch to build a "packaged" version of your code, and publish it to either the public PyPi repository or an internal one that you set up. Then your users can use pip to install your package, automatically fetch its dependencies, and keep it up to date, just like any other Python module.

You could maybe make it a click Application, and use setuptools.

Not sure how advisable it is to depend on setup.py given the setuptools team has very clearly stated that they are not interested in supporting any cli commands anymore including setup.py install. Relavant PR