ShellCheck VS PowerShell

not sure about unit/functional testing, but https://www.shellcheck.net/ is handy for linting and finding bad practice.

First, how did ShellSheck didn't give you warnings, if you checked it?

BTW, check out https://www.shellcheck.net/. You can install it to your computer and it'll warn you about this and many other ways you can accidentally shoot at your own foot with Bash.

This is super easy but, may not always be enough.. Luckily, the fine people at ShellCheck gave this some thought and created a nifty tool. It’s got a nice README, is available via most decent package managers and, even has a web interface where you can test snippets (in case you’re bored and on the tube, I guess). The README also includes a Gallery of bad code to showcase some of the stuff shellcheck can pick up on.

Bash because it's everywhere and I've put effort into learning it properly. My scripts almost always pass shellcheck first try, and I know the syntax of bash-specific features reasonably well. I don't see any advantage to learning another shell which I need to explicitly install and relearn all over again.

The Prompt logic could include some nuance to flag potentially harmful commands, but it would still be potentially fallible. However, you raise an excellent point, and value can be added by altering the workflow to run the results through a tool like shellcheck, where you can customize acceptable BASH commands.

Idea: Incorporate shellcheck that repeats the code back to the bot until it passes shellcheck at least.

A good way to learn the finicky bits is to run all your scripts through shellcheck. (Better yet, find a plugin for your editor/IDE.) If it flags an issue, read the corresponding wiki page and see if you understand it.

Have you run them through shellcheck? https://www.shellcheck.net/

Nice work! I recommend using https://www.shellcheck.net/ to make sure your bash script is in a good modern shape

Engine event processing bypasses "ShouldQueueAndProcessInExecutionThread" causing state corruption and crash due to Runspace affinity

Also it is MIT-licensed open source today: https://github.com/PowerShell/PowerShell

==> Downloading https://github.com/PowerShell/PowerShell/releases/download/v7.3.

NuShell is properly MIT-licensed, and is therefore Free Software.

Powershell is kind of MIT-licensed, except for the parts that aren't but are still an integral part of it, so not really, and is therefore not Free Software. At least, it's not DFSG-free.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834756

https://github.com/PowerShell/PowerShell/issues/5869

No, they don't ship curl, see https://daniel.haxx.se/blog/2016/08/19/removing-the-powershe... and https://github.com/PowerShell/PowerShell/pull/1901.

# escape=` # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. # Args used by from statements must be defined here: ARG InstallerEnvHost=mcr.microsoft.com ARG InstallerEnvRepo=windows/servercore ARG InstallerEnvTag=ltsc2022 ARG NanoEnvHost=mcr.microsoft.com ARG NanoEnvRepo=windows/nanoserver ARG NanoEnvTag=ltsc2022 # -------------------------------------------------------------------------------------------------------------------------------------- # STAGE 1 Build Environment # -------------------------------------------------------------------------------------------------------------------------------------- FROM ${InstallerEnvHost}/${InstallerEnvRepo}:$InstallerEnvTag AS installer-env1 # disable telemetry ENV POWERSHELL_TELEMETRY_OPTOUT="1" ARG PS_VERSION=7.3.2 ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v$PS_VERSION/PowerShell-$PS_VERSION-win-x64.zip ARG ZIP_VERSION=2201 ARG ZIP_PACKAGE_URL=https://www.7-zip.org/a/7z$ZIP_VERSION-x64.exe SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] RUN [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12; ` New-Item -ItemType Directory -Path C:\installer | Out-Null; ` Write-Output "Download PowerShell from $env:PS_PACKAGE_URL"; ` Invoke-WebRequest -Uri $env:PS_PACKAGE_URL -outfile C:\installer\powershell.zip -verbose; ` Expand-Archive C:\installer\powershell.zip -DestinationPath \PowerShell; ` Write-Output "Download 7-Zip from $env:ZIP_PACKAGE_URL"; ` Invoke-WebRequest -Uri $env:ZIP_PACKAGE_URL -OutFile C:\installer\7z.exe; ` Start-Process -FilePath C:\installer\7z.exe -ArgumentList '/S' -NoNewWindow -Wait -Verbose #Start the NanoServer Build of ePledge # -------------------------------------------------------------------------------------------------------------------------------------- # STAGE 2 Build Environment # -------------------------------------------------------------------------------------------------------------------------------------- FROM ${NanoEnvHost}/${NanoEnvRepo}:$NanoEnvTag AS installer-env2 COPY --from=installer-env1 ["/PowerShell", "/Program Files/PowerShell"] COPY --from=installer-env1 ["/Program Files/7-Zip", "/Program Files/7-Zip"] #Need to switch user to ContainerAdministrator in order to do a setx USER ContainerAdministrator RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell;%ProgramFiles%\Git\cmd;%ProgramFiles%\Git\usr\bin;%ProgramFiles%\7-zip" /M USER ContainerUser ARG GIT_VERSION=2.39.2 ARG GIT_PACKAGE_URL=https://github.com/git-for-windows/git/releases/download/v$GIT_VERSION.windows.1/PortableGit-$GIT_VERSION-64-bit.7z.exe ARG GH_CLI_VERSION=2.23.0 ARG GH_CLI_PACKAGE_URL=https://github.com/cli/cli/releases/download/v$GH_CLI_VERSION/gh_${GH_CLI_VERSION}_windows_amd64.zip SHELL ["pwsh", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] RUN [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12; ` New-Item -ItemType Directory -Path C:\installer | Out-Null; ` Write-Output "Download Git from $env:GIT_PACKAGE_URL"; ` Invoke-WebRequest -Uri $env:GIT_PACKAGE_URL -OutFile C:\Installer\Git.7z.exe; ` 7z x C:\Installer\Git.7z.exe -ogit; ` Write-Output "Download Git CLI from $env:GH_CLI_PACKAGE_URL"; ` Invoke-WebRequest -Uri $env:GH_CLI_PACKAGE_URL -OutFile C:\Installer\GHCLI.zip; ` 7z x C:\Installer\GHCLI.zip -ogit # -------------------------------------------------------------------------------------------------------------------------------------- # Final Build STAGE # -------------------------------------------------------------------------------------------------------------------------------------- FROM ${NanoEnvHost}/${NanoEnvRepo}:$NanoEnvTag AS nanoserver-git COPY --from=installer-env1 ["/PowerShell", "/Program Files/PowerShell"] COPY --from=installer-env1 ["/Program Files/7-Zip", "/Program Files/7-Zip"] COPY --from=installer-env2 ["/Git", "/Program Files/Git"] USER ContainerAdministrator RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell;;%ProgramFiles%\Git;%ProgramFiles%\Git\cmd;%ProgramFiles%\Git\usr\bin;%ProgramFiles%\7-zip" /M USER ContainerUser SHELL ["pwsh", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] #Create Base Level Directories RUN New-Item -ItemType Directory -Path C:\AdminScripts | Out-Null; ` New-Item -ItemType Directory -Path C:\AdminScripts\epledge-deploy | Out-Null; ` New-Item -ItemType Directory -Path C:\Users\ContainerUser\.ssh | Out-Null; ` Set-Location $ENV:ProgramFiles\Git # Copy Over Files & Folders COPY IdentityFiles C:/AdminScripts/IdentityFiles COPY .ssh C:/Users/ContainerUser/.ssh RUN git config --global core.sshCommand 'ssh -o StrictHostKeyChecking=no' CMD ["pwsh.exe"]

Only found this in the repo itself Changelog 7.3