obsidian-blog VS cool_ssg_generator

- Github project

I contributed on Le Minh Pham's project which was written in Python. Unit testing in python was a lot simpler than using Java. I created two unit testings, which have test cases for horizontal rules and a combined markdown feature. First I failed on horizontal rules testing, and had to discuss with Le Minh Pham, he was able to fix the part where it breaks the

After implementing my code I run some tests on my side when everything looks good. I commit, then push to remote then created a Pull Request #16. lmpham1 found a small bug in my code where I have to check correctly if it was a json file. After fixing it and pushed to the remote. lmpham1 merged my PR and the issue that was linked to it was closed automatically.

Changes I made

I find my partner- Le Minh Pham - through Slack and we both prefer Python. I just started learning Python, but he should be an expert. I learned some new libraries and methods after testing and reviewing Le’s code. I am surprised at the beautiful structure of his code. My partner helped me solve a big problem of finding folders, so I’m lucky to have such a partner. Reviewing and testing code is an exciting and painful thing for me. I'm excited because I can learn a lot of skills from my partner. For example, the original code only has one file, but after optimization, it has four files, and many auxiliary functions are added, and the structure is clearer. The pain is because as a new language, it takes me a long time to review and test it. Especially, my partner is very diligent. His code changes a lot every few days. Based on my level, it’s hard to find issues about his constantly improving code. Despite all this, I can still find problems and put forward what needs to be improved. For example, the issue “--input folder command line isn't working” https://github.com/lmpham1/cool_ssg_generator/issues/2 I also give some suggestion, for example, https://github.com/lmpham1/cool_ssg_generator/issues/3 There are 2 main issues about my code. https://github.com/Yoda-Canada/Magic-SSG/issues/1. https://github.com/Yoda-Canada/Magic-SSG/issues/2. Le give me lots of suggestion to fix the bugs, and I am fixing them. This lab is very important for me, because a lot of basic knowledge needs to be learned, and it also help me to recall the knowledge I learned before. I am confident to complete the future project