brave-core VS gecko-dev

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922

You can see how Mozilla tests the compliance of their built-in elements in the Gecko repository (the ok and is assertions are defined in their SimpleTest testing framework). And here's the Web Platform Tests' reflection harness, with data for each built-in element in sibling files, that almost every browser pass.

The source is mirrored on GitHub here: https://github.com/mozilla/gecko-dev

Code search is here: https://searchfox.org/mozilla-central/

Yes. https://github.com/mozilla/gecko-dev/tree/32c74afbb24dce4b5d...

aWheelInput.mDeltaY looks like the increment setting used for this https://github.com/mozilla/gecko-dev/commit/9033e3e1200acfd4b8f8ae024c215b99d12b97bdTried "mousewheel.default.delta_multiplier_y" and "mousewheel.with_control.delta_multiplier_y" without much luck.It may have something to do with https://bugzilla.mozilla.org/show_bug.cgi?id=1138704 although this case is about pinch zoom emulation.

You could add the feature by writing code to support is - https://firefox-source-docs.mozilla.org/setup/index.html

I checked Firefox monorepo, it has over 4x more C++ than Rust.

Are you leaving steps out or is your OP exhaustive? If you just straight up cloned release and that's it, start all over and follow https://firefox-source-docs.mozilla.org/setup/index.html for your OS