BinarySearchTreeExercises VS Options

Trippy and kind of cool. Don't remember if I knew that. I did make this red black tree map last May though. The only problem is I wrote the code without the key being const, but because a major part of my tree changing methodology was using std::swap which at the time I couldn't figure out how to replicate involving a const key, I left it that way. Partially it was due to the basis coming from following a tutorial in Java I think. But since it was only affecting me at the time with the iterator, I did a hack with some lambdas to make the iterator operators work like this:

This is theDS project that I have spent 2 weeks on and have not commented almost at all on. A red black tree map, I did not have anything well defined concerning how much I was going to end up doing with it, so it has evolved into what it is now. If I do anything more with it, it will probably be just to add in the rest of the special members and maybe 2 unary operators (+ and -) to the Iterator.

Regarding the formatting, it took me a little while but I installed clang-format and went through the options, it was close between google and gnu but I went with google. Does this look better? This is my current version of this class from my repository. RedBlackTree

The ordeal I have had with it makes me feel like it's full of duct tape and zip ties TBH. I am not in the know of benchmarking but using some timer class I found by googling; the run times for insertion and deletion of elements seem comparable between my raw version and the std::set. But like I indicated earlier, it is not a template class and we are only working with ints here. What I am wondering though is if an ideal erase() method is supposed really to be anywhere as long as mine turned out to be? Because seriously I felt like a dutch boy plugging holes on this thing for hours hahaha. Methods are below and entire class is available here https://github.com/sethvan/BinarySearchTreeExercise .

In case you have the time, I have another program from actually that same time period ( also in C but before I started commenting ) and that additionally after a friend gave me advice, I several months later refactored quite a bit to make it look cleaner and more self-explanatory. It currently has no comments I believe. Could you let me know if it's not clear enough without comments? The opposite scenario so to speak. If you have the time that is. This is it.