IPC144 VS IPC144

Go to the contributor's GitHub account and Clone the repo that they forked to write PR on, in this case, that would be IPC144 repo: git clone https://github.com/username/IPC144.git

Reviewing two PRs from a classmate is one of the duties for this project. The PRs, as well as my reviews, are available here and here. Both of the PRs I reviewed were really well-written and detailed, with very few mistakes. It was interesting to observe how different people approached certain changes, such as adding a svg file.

For this assignment we had to contribute to a Seneca repository. I chose the IPC144 repo.

Issue: https://github.com/Seneca-ICTOER/IPC144/issues/64 I worked on the standardized front matter across all markdown pages. This open-source project is the C language course notes of my major program.

And the reason why the web-only artifacts is still appear on the PDF page is because the --excludeSelectors option is not implemented enough. I have to add .clean-btn to the --excludeSelectors, the purpose of this is not to include the "On the page" artifact in side the PDF page. This is the final source code I have implement for this improvement and my pull request

I think I was able to do a good job meeting my goals I gave myself in my planning phase of this release. I was able to finish the issues well on schedule while balancing my other courses like I hoped and I was able to properly audit and fix both issues #122 and #123 without needing too many changes after review. What I learned from those two issues is the importance to read and checkout other issues/pull requests, especially for smaller repos. As I was told in the review for both my issues, I learned that the project recently made changes with how we would format the frontmatter. In PR #142 we no longer use the slug for pages due to inconsistency with links and we also need to include a description to follow the standardized Frontmatter as updated in PR #143.

The first issue I was working on IPC144 Course Note is about improving the usability of the PDF file generated from the website. All contents are generated inside the PDF, however, we want to get this better since some of the pictures are not showing properly, and also the web-only artifacts are still on the PDF, which we do not want it when we use the "PDF" version. convert-to-pdf.sh file would be modified a bit to accomplish this.

Issue #113

PR

As for this pull request, the code review went much more smoothly, with me having to only make minor changes to ensure that it would not cause any errors when built.

2. #issue-107