scroll-to-text-fragment VS brave-core

There were some privacy concerns, regarding leaking of user information: https://github.com/WICG/scroll-to-text-fragment/issues/76

This doesn't make sense. There is no mystery about how scroll-to-text fragments should work. They're documented e.g. here: https://github.com/WICG/scroll-to-text-fragment

It's call "Text Fragments", and it was introduced to Chrome more than one year ago. https://github.com/WICG/scroll-to-text-fragment

I think it works in Chrome and Edge, but not in Firefox.

I kind of want to be able to upvote this post three times: once for the actual projects (which sound really cool!); once for introducing me to the term/joke "rakit"; and once for teaching me about the scroll to text fragment API – I had no idea that was a thing!

The most disturbing example of this I found recently is the new auto-highlighting feature Google proposed to the W3C then YOLO'd into chromium before people's concerns were met, because they have control of it and don't need industry approval to get that to happen. Here's an example convo with some of these topics raised.

Per web.dev, it is for Chromium based-browsers and other browsers have not signaled intent to support. This is quite a rabbit hole. Very recently there has been some spec discussion if you follow links in the pages I've linked here.

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922