mapbox-gl-js VS brave-core

Good. Brave's fiddling with WebGL causes >50% of my bug reports from 1% of users.

[1] https://github.com/mapbox/mapbox-gl-js/issues/10518

[2] https://github.com/mapbox/mapbox-gl-js/issues/8377

Laravel and Mapbox GL JS

It originated as an open-source fork of Mapbox-gl-js before they switched to a non-open-source license on 8th December 2020.

Do you have programming skills? MapboxGL JS is a great library for stuff like this, you can really easily add a layer of GeoJSON data to a map. If you're looking for something less technical Google map lets you create custom maps where you can add a bunch of pins.

From the latest commits (not released/stable yet): git clone https://github.com/mapbox/mapbox-gl-js.git yarn install yarn run build-prod-min yarn run build-css Then use the generated mapbox-gl.js and mapbox-gl.css files. See CONTRIBUTING.md for more details.

> too bad it doesn't come with some code

Mapbox changed the license of their code last year I think to a proprietary one. https://github.com/mapbox/mapbox-gl-js/blob/main/LICENSE.txt

It requires a mapbox user license with billing enabled to use this code, let alone make modifications. But the source is viewable on github.

The software stopped being open source from v2 onwards. The new licence makes it merely shared source.

This GitHub issue where this change is announced provides a number of more in-depth explanations why this is a bad thing for most users of the software: https://github.com/mapbox/mapbox-gl-js/issues/10162

It's a bummer mapbox isn't open source anymore, now you're (and lots of other peoplare) are stuck pre-2.0.0 :(

https://github.com/mapbox/mapbox-gl-js/blob/main/CHANGELOG.m...

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922