golangci-lint VS maligned

Things I can't live without in a new Go project in no particular order:

- https://github.com/golangci/golangci-lint - meta-linter

- https://goreleaser.com - automate release workflows

- https://magefile.org - build tool that can version your tools

- https://github.com/ory/dockertest/v3 - run containers for e2e testing

- https://github.com/ecordell/optgen - generate functional options

- https://golang.org/x/tools/cmd/stringer - generate String()

- https://mvdan.cc/gofumpt - stricter gofmt

- https://github.com/stretchr/testify - test assertion library

- https://github.com/rs/zerolog - logging

- https://github.com/spf13/cobra - CLI framework

FWIW, I just lifted all the tools we use for https://github.com/authzed/spicedb

We've also written some custom linters that might be useful for other folks: https://github.com/authzed/spicedb/tree/main/tools/analyzers

Hey, I try to figure out an elegant way to integrate golangci into a Go project.

All of this is nitpicking really, but I would suggest using linters, e.g. https://github.com/golangci/golangci-lint - sometimes annoying, but mostly just helps to avoid discussions like this (and plethora of bugs).

You should always use golangci-lint, which includes errcheck.

golangci lint - https://golangci-lint.run/

Code inspection golangci-lint

I disagree with at least half of your post, tooling in Go is amazing overall and there is one linter that pretty much every one is using: https://github.com/golangci/golangci-lint

I've written betteralign, a tool to detect structs that would use less memory if their fields were sorted and optionally sort such fields. Truth be told, there are a few projects already doing this task perfectly such as fieldalignment, maligned and structslop so you might wonder why should you bother with checking this tool at all. This is a fork of an official Go fieldalignment tool and vast majority of the alignment code has remained the same. There are however some notable changes:

The standard way to check for these was https://github.com/mdempsky/maligned. It is now deprecated in favour of https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/fie....

You can now check for these using go vet:

go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/[email protected]

As PuzzleheadedHuman pointed out, there are readily available linters available to check this: https://github.com/mdempsky/maligned Which is integrated into golangci-lint. If you are seriously programming Go, you should be using that anyhow. Though I think that's not on by default, I also recommend anyone using golangci-lint read through everything it ships with. Many interesting ones are not turned on by default because they are very, very opinionated (such as this one), and a few of the defaults I turn off personally.

There are even linteners for that https://github.com/mdempsky/maligned