brave-core VS uAssets

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922

1. Force uBlock Origin out.

2. Reimplement its features selectively.

uBlock Origin comes with a filter called 'Block Outsider Intrusion into LAN'[0].

[0] https://github.com/uBlockOrigin/uAssets/blob/master/filters/...

Migrate to Firefox and install uBlock Origin, you will have this feature and more.

fixed https://github.com/uBlockOrigin/uAssets/commit/613159034ef6eed417516e90710474dfab42a808

BTW the whole issue was this, https://github.com/uBlockOrigin/uAssets/commit/de85f38ad297a6724d3f06d360f1693ab29599ad

Aternos is problematic. See issue https://github.com/uBlockOrigin/uAssets/issues/13144

Fixing anti-adblock may cause ads or breakages. If you see any issue, please report back the EXACT URL and your country when accessing the URL so volunteers are able to investigate by commenting here or in this thread on github.

Looking at the filters that uBlock is using, it still seems to be some sort of regex on the xhr request/response body [1]. Why can't youtube trivially defeat this by encrypting everything?

[1] https://github.com/uBlockOrigin/uAssets/commit/fb33bb3c1fa99...

a) How does ublock (-the extention-) upgrade . i suppose what that purge caches does is going to the repo and grabs the latest lists/ids etc ... but if during this battle you had to upgrade the extention itself was this done via the extention store or the the extention goes grabs the new version by it self ?

Mega thread issue on GitHub tracking this https://github.com/uBlockOrigin/uAssets/issues/19976

Reddit is not and should not be considered a tech support site.

YouTube is stepping up the anti-adblock nonsense and will be disabling playback after 3 videos

Personally, this sort of arms race is only going to cause me to not use YouTube

https://github.com/uBlockOrigin/uAssets/assets/47215043/f76f8ea2-3dd4-43ef-8293-353243cc5863

(Apologies if this was shared already)

Tracking issue for uBlock Origin: https://github.com/uBlockOrigin/uAssets/issues/19976