brave-core VS src

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922

Where is their source repo? Is it not this https://github.com/kiwibrowser/src? Which last commit was 4 months ago?

This is really cool, thanks for pointing it out! I have used Eruda and keep it in Tampermonkey in Firefox for use in a pinch but it's hacky. It's impressive that it works at all, but it's very difficult to do any actual work.

I already had Kiwi installed and it's neat to pop it open and see this feature hiding in plain sight. I won't use it as a daily driver though since it selectively blocks adblockers on a hardcoded list of domains which is just untrustworthy. https://github.com/kiwibrowser/src/blob/master/extensions/re...

You can try this: https://github.com/kiwibrowser/src/blob/master/.github/workflows/build_apk.yml

GitHub - kiwibrowser/src: Source-code used in Kiwi Browser for Android

Kiwi browser is a good alternative, it supports Chrome extention in Android and also half often source. Get it here https://github.com/kiwibrowser/src or https://play.google.com/store/apps/details?id=com.kiwibrowser.browser

Yup > https://github.com/kiwibrowser/src

Their GitHub does claim that it's "fully open-source": https://github.com/kiwibrowser/src

It is fully open source since 17th April 2020 https://github.com/kiwibrowser/src