brave-core VS brave-ios

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922

Making a better search on Github I found this in the iOS repo: https://github.com/brave/brave-ios/pull/3737 you can see they have some 'examples' in Test Plan.

Here's github ticket to track this problem https://github.com/brave/brave-ios/issues/6822

Brave on iOS uses Firefox's code base as a start for their app. If you check files like the Authors file you will find Mozilla employees who worked on Firefox iOS and never worked on Brave.

It is definitely a feature in Brave. Been around on Android for a while and they implemented it on iOS as well: https://github.com/brave/brave-ios/issues/3229

Ticket to track it here https://github.com/brave/brave-ios/issues/5668 Not sure about timing, we go hard at the Tab sync project right now

iOS has 415 open issues Brave Browser has 4,897 open issues And that list goes on. That's a LOT of stuff to go through and have to prioritize. If Brave truly doesn't have a lot of staff working on things.

As far as I'm aware, tab groups are not implemented in the iOS app. They seem to be planned, but it may be a while.

Can you post your design in this ticket? https://github.com/brave/brave-ios/issues/4002