GHSA-pjwm-rvh2-c87w VS is-odd

The SUNSPOT malware, Codecov breach, and lot of compromised open-source packages (like was the case with ua-parser-js) target the CI/ CD pipeline to modify release build or exfiltrate credentials.

I think you are misunderstanding the attack vector in the article you linked. This isn't the same thing we were discussing, please see https://github.com/advisories/GHSA-pjwm-rvh2-c87w. This was not a compromise designed to go after the visitors of the website so far as I can tell (and even if it were, it couldn't do much except possibly steal a password if you entered it on a compromised site or steal cookie data). This was designed to target people who were using the library in their software, aka, it was targeting the build-chain of the developers, and many devs and companies as a result had computers compromised when the updated their versions, which caused the compromised version to download to their computers.

Github has published an advisory for the package https://github.com/advisories/GHSA-pjwm-rvh2-c87w

Ridiculous as it may be, my guess is that provides a unified way of number checking while avoiding the pitfalls or crazy consequences which could arise from divide-by-zero[1], which I guess might prevent less-experienced folks from tripping up on some of the Javascript gotchas? I'm not really sure. That being said, I have seen those package dependencies in some serious stuff.

Do I agree? I'm not really sure to be honest. Probably not.

[0] https://github.com/i-voted-for-trump/is-odd/blob/master/READ...

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Refe...

it gets worse: https://github.com/i-voted-for-trump/is-odd/blob/master/index.js

So it disappeared and node apps stop building and it was a huge fiasco getting it restored. Just for reference, https://github.com/i-voted-for-trump/is-odd is a current fork of it and it has 34M downloads.

Checks of this extensiveness would be mad for such a simple library. I mean, who would use a library with that extensive checks?

I think that this approach would cut down the amount of JS dependencies significantly. Things like is-even and is-odd come to mind. You don't want another leftpad or colors.js to happen to you and minimising dependencies is the most effective strategy to accomplish that.

So many leaf dependencies I've looked into are no more than a Stackoverflow answer in a JS file accompanied by six or seven metadata files (package.json + typescript files + linter config + readme + git config + ...). This file: https://github.com/i-voted-for-trump/is-odd/blob/master/inde... is downloaded over 400000 times per week (https://www.npmjs.com/package/is-odd) and while I don't have anythimg against the author for publishing a helpers function, I don't see why I would expose my project to risking a supply chain attack for something so minor. Here's another, with millions of downloads: https://github.com/inspect-js/is-date-object/blob/main/index...

I know that these are all downloaded so ofyen because theyre dependencies of dependencies but I'd appreciate it if bigger libraries would provide a vendored version of their packages that just collects these microdependencies instead of wasting npm's time by making it manage these tiny helper files. Don't vendor stuff like React or Vue or whatever framework you prefer but for the love of God don't add a dependency for 50 lines of code. Sometimes copy/paste is the right solution.

$ npm install --save is-odd // https://www.npmjs.com/package/is-odd // This package has about 500k weekly downloads // https://github.com/i-voted-for-trump/is-odd/blob/master/index.js module.exports = function isOdd(value) { const n = Math.abs(value); return (n % 2) === 1; };

I started reading your comment curious about the source code. But I finished reading your comment only more curious. So I went to GitHub's "is-odd" and I've come back to give everyone *is-odd'*s source code in it's entirety. And here it is: