pianochord.io VS tonal

Your F, defined on line 26 [0], is 4Hz off according to this reference table[1]. 346.23 should be 349.23. Just a typo?

All credit to @issa's ear. And yes, while you'd be unlikely to have encountered this bug if you were just telling a good existing synth to play an F, it's cool that you implemented the synth from scratch! Whether it's a good choice depends on the project goals.

[0] https://github.com/JNKKKK/pianochord.io/blob/master/src/libs...

[1] https://pages.mtu.edu/~suits/notefreqs.html

They're using objects, including arrays [1], so I think they would have been more precise to say that they're using objects and arrays as simple data structures rather than using OO features like inheritance and mutation.

[1] https://github.com/tonaljs/tonal/blob/main/packages/chord/in...

It's not on this list, but it's a cool list to check out either way

I'm working on a music project and both tonejs and tonal are incredible projects.

Regarding the "Music Theory library" aspect, note that the CLI tool demonstrates use of the underlying Ruby library which has documentation here:

* https://github.com/pedrozath/coltrane/wiki/Core-music-theory...

Additionally, the author wrote a post about the motivation for creating the library but it's a little difficult to find via the (now broken) link in the README, so here is a direct link to the archived page on the Wayback Machine:

* https://web.archive.org/web/20170714063625/https://medium.co...

If anyone is interested in a similar music theory library for Javascript[0] I've had some success with this:

* Tonal / Tonal.js https://github.com/tonaljs/tonal

[0] Or, in a pinch, even with a Godot 4 web export as I did for my (very incomplete) "AI and Games" Game Jam entry: https://rancidbacon.itch.io/the-conductor (For reasons far too convoluted to go into now.)

There are many hundreds of scale types, here's a list of many of them and that's just a single key. Let's say there's 200 scales times 12 for each key, that's 2400 times up and down the piano. There are actually much more than 200 scales though!

I found a module that is perfect for what I'm trying to create, (a simple piano that you can select keys on to find out which chord it gives), and am trying to use https://github.com/tonaljs/tonal .

Agree with the representation, you can really bury yourself in complexity if you're not careful. Have you taken a look at any of the JS libraries like tonal or MusicTheoryJS?

Here's how tonal.js does it: https://github.com/tonaljs/tonal/tree/master/packages

For the music theory stuff I'm using TonalJS along with my own extensions