phpinspectionsea VS black

(I actually held the same opinion as you until recently: https://github.com/kalessil/phpinspectionsea/issues/1718 tl;dr the performance impact is negligible)

See here for some background https://github.com/kalessil/phpinspectionsea/issues/1823 although some things seem to not add up (see last comments, the repository maintainer is active on GitHub but does not commit fixes readily prepared by others).

PHP Inspections is a static code analyzer and code review tool for PhpStorm IDE.

The PHP-EA Extended static analysis plugin for PHPStorm has a number of Performance rules which has some of the same items as this list, although they're not all in the performance category, the single quotes inspection is under code style.

PHP Inspections (EA Extended)[1] by Vladimir Reznichenko, a PHP language static analysis plugin for PHPStorm / JetBrains. I've coded in PHP for many years now, but there are many helpful reminders and checks that come standard with it. Some of the small performance quirks are game changers in long running processes, or intensive methods.

[1]: https://github.com/kalessil/phpinspectionsea

repos: - repo: https://github.com/pre-commit/pre-commit-hooks rev: v4.4.0 # Use the desired revision hooks: - id: trailing-whitespace - id: end-of-file-fixer - repo: https://github.com/psf/black rev: 23.1.0 # Use the appropriate version for your project hooks: - id: black - repo: https://github.com/pycqa/flake8 rev: 6.0.0 hooks: - id: flake8

> I appreciate that Black annoyed everyone on our team about the same amount but in different ways.

If it did affect people equally, it would be great. Unfortunately, spaces for indentation is an accessibility issue and the Black maintainers are hostile to making this configurable. Normally I am in agreement about minimising configurability, but this isn’t a matter of taste, it is making the Python ecosystem more difficult for some disabled people to participate in.

https://github.com/psf/black/issues/2798

Fortunately, Ruff makes this configurable, so you don’t have to choose between autoformatting and accessibility any more.

XO. This feels like the Black of Typescript linting. XO has styles for everything and is very opinionated. This can be nice, because it takes a lot of code style decisions off of your plate. But beware it can be cumbersome to implement in the middle of a project because it will require extensive reformatting. In lieu of XO, I found Unicorn opinionated enough and more immediately useful.

Black (Python Code Formatter) - Black is a widely used opinionated Python code formatter that helps standardize the look of Python code. Its primary advantage is that it eliminates arguments over style, helping teams stay productive.

repos: - repo: https://github.com/psf/black rev: 22.3.0 hooks: - id: black args: [--line-length=79] - repo: https://github.com/PyCQA/isort rev: 5.10.1 hooks: - id: isort - repo: https://github.com/PyCQA/flake8 rev: 4.0.1 hooks: - id: flake8