code-review-emoji-guide
code-review-checklist
code-review-emoji-guide | code-review-checklist | |
---|---|---|
8 | 4 | |
431 | 843 | |
- | - | |
0.0 | 2.0 | |
about 2 years ago | 4 months ago | |
- | MIT License |
Stars - the number of stars that a project has on GitHub. Growth - month over month growth in stars.
Activity is a relative number indicating how actively a project is being developed. Recent commits have higher weight than older ones.
For example, an activity of 9.0 indicates that a project is amongst the top 10% of the most actively developed projects that we are tracking.
code-review-emoji-guide
-
Do you guys give/get positive feedback in code reviews?
I give it here and there, depends how much time I have. I recommend using an emoji code if you don't already as it allows you to easily give positive feedback or mark areas for tech debt etc: https://github.com/erikthedeveloper/code-review-emoji-guide
- Difficulties in mentoring junior and mid level developers
-
How do you prevent PRs from getting stuck in your teams?
self reviewing your PRs definitely makes it easier for reviewers to ramp up fast. i found setting review guidelines (https://github.com/erikthedeveloper/code-review-emoji-guide for example) helps give good actionable reviews (especially for self reviews)
-
Code review comments / slack messages often ignored
setting standards so that you're all on the same page wrt tone and circulating that internally could help. There's a code review emoji guide you could use (it's the first result in google for "code review emoji guide") or you could write your own. This can help make it more likely that no one is misinterpreting you (although it's impossible to make certain of this).
-
Do people think your PR comments sound arrogant or judgmental?
I like the ⛏ "pickaxe" emoji for these ('pickaxe' as in 'pick' as in 'nitpick').
-
Bluntly: how do I know if I'm a shit programmer
Try suggesting an emoji code review process: https://github.com/erikthedeveloper/code-review-emoji-guide
-
How do you deal with snarky PR comments?
Nice. I’ve used this emoji system and it works quite well too.
code-review-checklist
- Code Reviews ebook
- Code reviews resources
-
Doesn't look good to me — a requiem for thorough code reviews
Below is my full checklist, based on what I think is important, and also inspired by other checklists out there. If you're looking to adopt a checklist in your team, I suggest you use one that encapsulates the properties your team thinks is important. There's plenty of good checklists around the web to use as source material.
-
Developer checklist
There is this checklist.
What are some alternatives?
all-about-code-review - This is a curated list of resources about code reviews: articles, tools, trainings...
github-issue-templates - 🔣 A collection of GitHub issue, pull request and security templates
hantsy - it's me
Qodana - 📝 Source repository of Qodana Help
codewars.com - Issue tracker for Codewars
dev - Press the . key on any repo
effective-code-review - Presentation about my process for making code reviews as effective as possible
go-concurrency - Checklist for code reviews
dev - Development repository for the CodeMirror editor project
amazing-github-template - 🚀 Useful README.md, LICENSE, CONTRIBUTING.md, CODE_OF_CONDUCT.md, SECURITY.md, GitHub Issues, Pull Requests and Actions templates to jumpstart your projects.
Clean-Code-Notes - My notes of Clean Code book