angular-eslint VS universal

Until I recently discovered that angular-eslint had added a new lint rule in v16.2 called prefer-self-closing-tags that can be used to enforce this syntax partially or throughout a project.

We are also using angular-eslint which now supports 16.0.3 so that was painless.

Along the lines of Angular ESLint, are there any packages that provide ESLint rules around writing SSR friendly code?

{ "root": true, "ignorePatterns": ["projects/**/*"], "rules": { "prettier/prettier": [ "error", { "endOfLine": "auto" } ] }, "overrides": [ { // TODO: find a way to apply rules on all files ending with .ts except for files ending with .stories.ts "files": ["*.ts"], "extends": [ "eslint:recommended", "plugin:@typescript-eslint/recommended", "plugin:@angular-eslint/recommended", "plugin:@angular-eslint/template/process-inline-templates", "plugin:prettier/recommended" ], "rules": { // https://github.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin/docs/rules "@angular-eslint/directive-selector": [ "error", { "type": "attribute", "prefix": "hv", "style": "camelCase" } ], "@angular-eslint/component-selector": [ "error", { "type": "element", "prefix": "hv", "style": "kebab-case" } ], // https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/docs/rules "@typescript-eslint/member-ordering": "error", "@typescript-eslint/naming-convention": "error", // https://eslint.org/docs/latest/rules/ "default-case": "error", "default-case-last": "error" } }, { "files": ["*.html"], "extends": [ "plugin:@angular-eslint/template/recommended", "plugin:prettier/recommended" ], "rules": { // https://github.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin-template/docs/rules "@angular-eslint/template/no-duplicate-attributes": ["error"], "@angular-eslint/template/attributes-order": ["error"], "@angular-eslint/template/no-call-expression": [ "error" ], "@angular-eslint/template/accessibility-elements-content": [ "error", { "allowList": [ "ariaLabel" ] } ], "@angular-eslint/template/accessibility-valid-aria": [ "error" ] } }, { "files": ["*.stories.@(ts|mjs|cjs)"], "extends": ["plugin:storybook/recommended"] // https://github.com/storybookjs/eslint-plugin-storybook/tree/main/docs/rules // "rules": {} } ] }

I don't think it's crazy, but these things improved my code quality a lot: * Use Prettier, an opinionated code formatter. It formats your code, no configuration, no fights with your colleagues. * Use eslint and SonarLint. They help you find bugs before you even commit your code. * Try to achieve a very high code coverage. Not every line needs to be covered, but I personally feel better if I've got 90+% coverage. It's not that hard once you include it in your coding-DNA. * Setup your IDE to properly debug your code. Don't do console.log(), use debugger; statements or real conditional breakpoints. Nothing sucks more than not being able to find out what your code really does. * Learn the ES6 and later features. Many developers tend to code in old ways (as they are used to), but JavaScript can do so much more these days. You'll save a lot of time and effort applying these new features. Start with Arrow Functions, followed by Rest and Spread operator, Property Shorthand and * Destructuring . Also note that there are some awesome new datastructures like Map and Set. * Learn TypeScript and keep yourself up to date. There are so many anti-patterns (never ever use any) that degregate your fancy, strictly typed highlevel code to buggy ES-code. It also helps a lot to reduce DRY and boilerplate. * Learn rxjs and use it on a daily base. Angular itself is really reactive as most Angular services return Observables that can be further processed with rxjs. Once your mind made the switch, you won't really use regular Events and/or loops anymore. But be aware of how to properly test your rxjs pipelines. * If you are integrating a remote API, I have very good experiences with OpenAPI and it's code generator for Angular. You will get ready-to-use interfaces and services just from an OpenAPI specification (which you get as a gift for many of the modern backend frameworks). Saves a lot of time and boilerplate code and removes the need to test and debug API-layer code. Your build will break as soon as the API introduces a breaking change, which is exactly what you want (it's too late if your app breaks on production)

If you're not already using Angular ESLint, you can add it to an Angular project by running the schematic:

ng add @angular-eslint/schematics ℹ Using package manager: npm ✔ Found compatible package version: @angular-eslint/[email protected]. ✔ Package information loaded. The package @angular-eslint/[email protected] will be installed and executed. Would you like to proceed? Yes ✔ Packages successfully installed. All @angular-eslint dependencies have been successfully installed 🎉 Please see https://github.com/angular-eslint/angular-eslint for how to add ESLint configuration to your project. We detected that you have a single project in your workspace and no existing linter wired up, so we are configuring ESLint for you automatically. Please see https://github.com/angular-eslint/angular-eslint for more information. CREATE .eslintrc.json (984 bytes) UPDATE package.json (1511 bytes) UPDATE angular.json (3447 bytes) ✔ Packages installed successfully.

We need two tools to get the job done. The first tool that we need is a pre-commit tool that runs for every git-commit action: Husky. The second tool that is needed is lint-staged, which will run specified scripts on matching staged files. Aside from these tools, we need a code repository with actual linting tools. We will be using an Angular project as an example with the Angular ESLint and Prettier pre-configured.

You can find all necessary tools and information to simplify the migration of existing Angular projects to ESLint at the GitHub Repo Angular ESLint.

Going to the source code of the CommonEngine we have this:

Angular executes applications in the browser and renders pages in the DOM by default. This default method of rendering in the client comes with disadvantages like poor performance and lack of visibility for search engine crawlers. Luckily, Angular allows us to opt-in for server-side rendering (SSR) through Angular Universal, its official SSR solution.

Example rules based on Angular Universal's gotchas:

About standalone support there's this issue in angular/universal and yes, it is supported now 🥳 Tomorrow I'll try making it work in local

Actually I notice in the last few days they might have done a fix for it = https://github.com/angular/universal/issues/1795

export function app(): express.Express { const server = express(); const distFolder = join(BROWSER_FILES_BASE_PATH, 'angular'); const indexHtml = existsSync(join(distFolder, 'index.original.html')) ? 'index.original.html' : 'index'; // Our Universal express-engine (found @ https://github.com/angular/universal/tree/main/modules/express-engine) server.engine( 'html', ngExpressEngine({ bootstrap: AppServerModule, }) ); server.set('view engine', 'html'); server.set('views', distFolder); server.use( '/browser', express.static(join(BROWSER_FILES_BASE_PATH, 'remix'), { immutable: true, maxAge: '1y', }) ); server.get( '/remix*', createRequestHandler({ build: require('../build/server/remix'), }) ); // Example Express Rest API endpoints // server.get('/api/**', (req, res) => { }); // Serve static files from /browser server.get( '*.*', express.static(distFolder, { maxAge: '1y', }) ); // All regular routes use the Universal engine server.get('*', (req, res) => { res.render(indexHtml, { req, providers: [{ provide: APP_BASE_HREF, useValue: req.baseUrl }], }); }); return server; }

I've located the module that already deals with the GET requests = https://github.com/angular/universal/blob/main/modules/common/src/transfer_http.ts So I've made my own interceptor and replaced the GETs mentioed on lines 75 and 95, however it doesn't seem to work. Only thing I can see is the original code references BrowserTransferStateModule which is crossed out. Do I need to replace that with something else?

Do you inject a token that is provided by SSR? Even though standalone has not reached ExpressEngine, but if you have the root AppModule and the root AppComponent non standalone, you can still use provideHttpClient. To inject a server provided string (specifically, the serverUrl), you can use inject function like this: