Our great sponsors
-
telescope
A tool for tracking blogs in orbit around Seneca's open source involvement (by Seneca-CDOT)
-
-
SurveyJS
Open-Source JSON Form Builder to Create Dynamic Forms Right in Your App. With SurveyJS form UI libraries, you can build and style forms in a fully-integrated drag & drop form builder, render them in your JS app, and store form submission data in any backend, inc. PHP, ASP.NET Core, and Node.js.
Telescope Link: https://github.com/Seneca-CDOT/telescope/pull/3762/files/87742e87eac0b136f6f53b0c38c2679f03317abd This is a PR made by Piotr to modify the documentation to provide a solution for data not showing up after the project is set up. This problem was found by me and Piotr while we are trying to work on the issue 3639. In this code review, Piotr updated the documentation for specific detailed steps we need to do after initializing the project in our local environment. I found at the end of the document he modified, a generalization of the problem and solutions is mentioned, however, the fact that the parser needs to be restarted after db:init was not mentioned, so I made a code review on this trying to amend it.
MyPhotoHub Link: https://github.com/humphd/my-photohub/pull/9/files/f65ac86f3321207953d66b02c9b9fff1942828f1 This PR was made to make an initial implementation for this project. In this project, I found that the Regular Repression that matches a parameter was hard-coded and has occurred more than once. I think this might not be a good practice to hard code it on every occurrence since it's not future-proof when the regular expression needs to be changed. If this Regular Expression could be referenced from a variable or configuration file, it would make the future changes on it way less headache.