Our great sponsors
-
-
SurveyJS
Open-Source JSON Form Builder to Create Dynamic Forms Right in Your App. With SurveyJS form UI libraries, you can build and style forms in a fully-integrated drag & drop form builder, render them in your JS app, and store form submission data in any backend, inc. PHP, ASP.NET Core, and Node.js.
During the testing and reviewing for her code, I have encountered both minor and major issues. Minor issues are related to documentation: there was a mismatch between actual functionalities and the options in Help section and Readme file was missing installation guide. Both were quickly resolved after the issues were filed.
The major issues are related to the main feature. At first, the tool was unable to process input that has spaces. She was using Yargs to parse the arguments, however, arguments are separated with space by default so if the input includes spaces, Yargs will parse only the first word into the option. I suggested that she looked into argv.input to find the solution. Another issue was that when a directory is specified as input, the tool would process all files inside regardless of the file type. When I looked at her code again, I could see that she was missing a check for file extension.
Vivian found a bug with my stylesheet feature. The title is defined as the first line of the file followed by two new lines. Some files have a title and some don't. My tool was assuming that every file has a title, hence failed to do the check. Therefore, if the input file doesn't have a title, the tool will generate the wrong title for it. I was able to fix this by adding a quick check before creating the HTML file.