connect VS brave-core

It returns some html that has some javascript. The JavaScript being returned is not defined in the extension repo - but the trezor connect repo https://github.com/trezor/connect

In this thread, you can find different troubleshooting tips: https://github.com/trezor/connect/issues/784.

"Manifest not set. Read more at https://github.com/trezor/connect/blob/develop/docs/index.md"

Starting with Trezor Connect 7, we have implemented a new feature — Trezor Connect Manifest — which requires that you as a Trezor Connect integrator, to share your e-mail and application url with us. This provides us with the ability to reach you in case of any required maintenance. This subscription is mandatory. Trezor Connect raises an error that reads "Manifest not set. Read more at https://github.com/trezor/connect/blob/develop/docs/index.md" if manifest is not provided.

The Trezor window that comes up when you confirm a transaction in metamask, quickly disappears and the transaction gets stuck in metamask. It is described in complete detail here, here and here.

Anyone familiar with this issue? https://github.com/trezor/connect/issues/784

Trezor Connect Changelog

We've been receiving reports that some of you are still experiencing this issue with Metamask. If it's your case, it would be helpful if you could describe your setup (OS, browser and its version, Trezor firmware, MM version) in this post. The details will be shared with our testers.

Hi, what browser and what version of Metamask you’re using? This issue was fixed by Metamask devs in the 10.8.0 version. You can find more details at https://github.com/trezor/connect/issues/784

Unrelated but about Brave and interesting to me: I recently found myself having a large upstream project that I need to maintain some custom patches for, and there's a need for deeper customizations and I worry that my rudimentary system of applying .patch files will turn into an unmaintainable nightmare of merge conflicts after every rebase. I was thinking about possible solutions, and it occurred to me that Brave being Chromium-based must have this same challenge but an order of magnitude more difficult, so I looked for their code to see how they solved this issue.

It's pretty interesting! They do basically the same thing for core Chromium, applying a (big) set of patches[1].

Incidentally, I'd be interested to hear any ideas/approaches to this problem. I'm guessing if there was something clearly better, Brave would be doing it, but it seems like there should be a better way even if I can't think of one.

[1] https://github.com/brave/brave-core/tree/master/patches

https://github.com/brave/brave-core/pull/13737

(Incidentally, that PR number is not quite elite. :)

I disagree that it's lip service Brave has a ton of engine level privacy patches https://github.com/brave/brave-core/tree/master/patches

To my understanding you can't match it with just js extensions.

Only firefox on the highest security mode comes close I think?

Or ungoogled chromium? (brave has most of their patches IIRC)

Are there other options that have this number of patches?

Chromium is not 100% Google's forever and always, though they do currently lead the way, and with the most used/backed fork.

https://github.com/brave/brave-core/pull/19476

They have much more changes than just compile flags. Here's the repo where they maintain their patch set: https://github.com/brave/brave-core/tree/master/patches

Brave Private Ads toggle controls just Push Notification ads at this time. So, if you are still seeing Push Notification ads, that would be incorrect. However, it's normal to still see New Tab Page image ads, and/or other ad formats. We are introducing a new UI that helps you better toggle on/off specific ad units, and removing the "Brave Private Ads" toggle that can be confusing: https://github.com/brave/brave-core/pull/18938

Yes, being fixed. Github at https://github.com/brave/brave-core/pull/18922