ShellCheck VS stan

not sure about unit/functional testing, but https://www.shellcheck.net/ is handy for linting and finding bad practice.

First, how did ShellSheck didn't give you warnings, if you checked it?

BTW, check out https://www.shellcheck.net/. You can install it to your computer and it'll warn you about this and many other ways you can accidentally shoot at your own foot with Bash.

This is super easy but, may not always be enough.. Luckily, the fine people at ShellCheck gave this some thought and created a nifty tool. It’s got a nice README, is available via most decent package managers and, even has a web interface where you can test snippets (in case you’re bored and on the tube, I guess). The README also includes a Gallery of bad code to showcase some of the stuff shellcheck can pick up on.

Bash because it's everywhere and I've put effort into learning it properly. My scripts almost always pass shellcheck first try, and I know the syntax of bash-specific features reasonably well. I don't see any advantage to learning another shell which I need to explicitly install and relearn all over again.

The Prompt logic could include some nuance to flag potentially harmful commands, but it would still be potentially fallible. However, you raise an excellent point, and value can be added by altering the workflow to run the results through a tool like shellcheck, where you can customize acceptable BASH commands.

Idea: Incorporate shellcheck that repeats the code back to the bot until it passes shellcheck at least.

A good way to learn the finicky bits is to run all your scripts through shellcheck. (Better yet, find a plugin for your editor/IDE.) If it flags an issue, read the corresponding wiki page and see if you understand it.

Have you run them through shellcheck? https://www.shellcheck.net/

Nice work! I recommend using https://www.shellcheck.net/ to make sure your bash script is in a good modern shape

However, I'm a huge fan of static tools like this in general. I've heard great things about https://package.elm-lang.org/packages/jfmengels/elm-review/latest/ and I need to try out https://github.com/kowainik/stan. Also its possible HLint has ways to write more advanced rules and I just don't know about them, but even if that's so hopefully I've explained why just dropping it in isn't a huge win.