pashword VS clsx

This is beautifully done, great design work.

Scrypt for password stretching seems good. I see you're using CPU cost of 2^15. When storing a password hash you'd want to use 2^17 (with agility to change algorithm or increase cost in the future) [1]. Since you're not storing the result, I suspect the lower number is reasonable.

I don't like simple concatenation when building a salt from two variable length fields. You'll get the same salt for `"foo" + "bar"` and `"foob" + "ar"`, but the salt should be unique. Although I don't think that's an issue for this project since the first is a website.

Using the website in the salt has some issues when there are multiple domains that use the same password. Do I use mail.google.com, auth.google.com, or google.com? trello.com or atlassian.net? What if the website it bought and the new owner changes the domain name? With a password manager, I can just look in my vault to figure out the old domain name.

Phishing is a major way passwords are stolen and this project doesn't seem to do anything to protect against that. A browser extension (and mobile app), that checks the domain name before showing/filling the password could help.

The secret key field let me use `1234` as the key, although the color of the field was red. I think this should either prevent obviously weak passphrases or show a much more obvious warning if when one is used. Using a password found in a breach is also a bad idea (even it the password looks strong). You don't have a way to check HIBP, so users will be vulnerable if they make that mistake. It's too easy to make a critical mistake with the current design.

A bug: I filled out the form but forgot to enable JavaScript. The form posted my passphrase back to the server (https://pashword.app/?website=google.com&username=me&passphr...). I'd recommend changing the form so the submit button doesn't do anything when JS isn't loaded, otherwise the server will learn users passphrases. This is also a good place to remember that the user fully trusts that you wont steal their info (I'm not sure why anyone should trust that).

Also check out other similar projects, lots of discussion which likely applies here as well. I believe one of these supports uses a counter to support password rotation. You'd just need to remember the counter value for each site.

* LessPass - https://news.ycombinator.com/item?id=12889807

Just take a look here: https://github.com/pashword/pashword/blob/main/pages/index.tsx

I'm looking for something close to https://pashword.app

Password managers can be a bit hard to manage, people don't even bother using them. There's https://pashword.app that solves this but not many people know about it.

clsx is a tiny utility for constructing className strings conditionally, I use it in conjunction with tailwind-merge which merges Tailwind CSS classes without style conflicts.

I am familiar with the library clsx although I have never used it personally. I don't often have the need for conditional classes and when I do it's usually an inline ternary expression in the style or className prop. Is that bad/good? Are there any other popular libraries other than clsx, or anti-patterns I should be aware of when doing conditional classes in React? Thanks fam

I use CLSX for all tailwind dynamic styles. Super simple, lightweight and now is almost part of every project I build haha

Clsx

https://github.com/lukeed/clsx “A tiny (228B) utility for constructing className strings conditionally.”

Then use something like clsx

For conditionally applying or removing classes, you should take a look at clsx.

clsx has better performance over the classnames package. That’s why it was created. Take a look at their benchmarks in the repo.

Hey, I'll have you know I have lots of fun using Tailwind with clsx =)

Next.js Redux Toolkit Framer Motion Tailwind Radix UI Radix colors react-use clsx lodash ms