algebra VS Clippy

Is ark a prefix Embark is using for all their Rust crates, or is it a one-off name for your future crate? If so, it might collide with our naming convention in the arkworks ecosystem: arkworks.rs

Fix almost_swapped false positive (let mut a = b; a = a)

I wish Google would invest more in go vet so it could do many of the things for which we currently rely on hobby-level tools that are rarely matured and often abandoned. ESLint, Clippy, and even clang-tidy show how much more comprehensive and mature lint suites can be, despite Go being easier to analyze than those languages.

This audit of lints from 2020 was in the back of my mind. I knew adding a lint that was widely ignored would only be bad for Clippy.

I believe a rust zero sized array ([T; 0]) inside of a #[repr(C)] struct behaves the same way as in GCC (can’t find a reference for it, but this thread kinda implies it), outside of that you might be able to use #[repr(align(n))] to achieve the same thing. Rust also contains unsized types, which can only be accessed through a layer of indirection, most prominently dyn Trait which is used for dynamic dispatch and [T] which is a contiguous piece of memory, the pointer to which stores its length.

Issue is here: https://github.com/rust-lang/rust-clippy/issues/10354

Can you perchance reduce your code to a reproducer? We had some perf problems within clippy recently (notably #10134), perhaps clap's macro expands to something that triggers this?

it's integrated (current repo is here: https://github.com/rust-lang/rust-clippy/), just do cargo clippy

when you say "clippy's repo hasn't been updated since 2019", which repo are you talking about? If I google for rust clippy, the first hit I get is this: https://github.com/rust-lang/rust-clippy which has commits yesterday.

I guess the way to go here would be asking to extend the needless_return clippy lint to also check for returns whose expressions diverge. Feel free to open an issue for this.